Re: [PATCH v2] soc/lapis: add machine driver

[Tomoya MORINAGA]

Hi Mark,

First of all, let me confirm my understanding for machine driver.
According to "machine.txt", I created this machine driver referring
corgi.c/spitz.c.
However, corgi.c/spitz.c. don't look obeying your saying.

e.g.
2011/12/3 Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>:
>> +     snd_soc_dapm_add_routes(dapm, ml7213_routes, ARRAY_SIZE(ml7213_routes));
>
> Use table based init for these.
>
I  couldn't see any table based init processing at corgi.c/spitz.c.

>
>> +     switch (params_rate(params)) {
>> +     case 16000:
>> +     case 32000:
>> +     case 48000:
>> +             clk = 12288800;
>> +             break;
>
> You may as well just set the CODEC clock rate once on init() and let the
> CODEC driver worry about what it can do with the clock it's got, if the
> values aren't going to change there's no need to set them every time.
>

corgi.c/spitz.c look coded like above.

So, I'm confused.
Is this procedure true ?


Thanks,

tomoya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/