Re: Re: [PATCH resend 2] x86, olpc-xo15-sci: Enable lid close wakeupcontrol through sysfs
From: Alan Jenkins
Date: Sun Dec 04 2011 - 06:50:21 EST
On 01/-10/37 20:59, Andrew Morton wrote:
Let me fix that for you.
--- a/arch/x86/platform/olpc/olpc-xo15-sci.c~x86-olpc-xo15-sci-enable-lid-close-wakeup-control-through-sysfs-fix
+++ a/arch/x86/platform/olpc/olpc-xo15-sci.c
@@ -58,7 +58,8 @@ static ssize_t lid_wake_on_close_store(s
const char *buf, size_t n)
{
unsigned int val;
- if (!sscanf(buf, "%u",&val) == 1)
+
+ if (sscanf(buf, "%u",&val) != 1)
return -EINVAL;
set_lid_wake_behavior(!!val);
It's kinda irritating that this will cheerfully accept bogus input of
the form "42foo". This happens about eleven billion times in sysfs
write() handlers but afaik we've never implemented a nice
sysfs_int_from_buffer() thingy which handles all the possible errors.
I thought there was.
strict_strtoul() ?
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/