[PATCH] leds: Use kcalloc instead of kzalloc to allocate array

From: Thomas Meyer
Date: Sat Dec 03 2011 - 03:21:48 EST


The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107

Signed-off-by: Thomas Meyer <thomas@xxxxxxxx>
---

diff -u -p a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c
--- a/drivers/leds/leds-mc13783.c 2011-11-13 11:07:27.873510772 +0100
+++ b/drivers/leds/leds-mc13783.c 2011-11-28 19:59:58.327155325 +0100
@@ -280,7 +280,7 @@ static int __devinit mc13783_led_probe(s
return -EINVAL;
}

- led = kzalloc(sizeof(*led) * pdata->num_leds, GFP_KERNEL);
+ led = kcalloc(pdata->num_leds, sizeof(*led), GFP_KERNEL);
if (led == NULL) {
dev_err(&pdev->dev, "failed to alloc memory\n");
return -ENOMEM;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/