Re: Add simple way to add statistic counters to debugfs

From: Greg KH
Date: Fri Dec 02 2011 - 14:19:49 EST


On Fri, Dec 02, 2011 at 10:43:24AM -0800, Andi Kleen wrote:
> This extends debugfs to make it very simple to add per cpu counters
> statistics that are exported there. This is useful for all kind
> of debugging situations. The counters have very little overhead
> and are simpler to use than trace points.
>
> This is the infrastructure for debugfs and a demo application
> to instrument the dcache RCU which I developed some time ago
> to track down some problems there.
>
> Posting here also so that Fengguang can use it.
>
> Module support is still missing, but could be added without too
> much work.

I like this a lot, very nice job. I just had one comment with the first
patch.

And yes, I would like module support as well, but others can add that if
they really need it :)

Care to fix up the first patch and I'll be glad to take the two debugfs
patches and any others if you want me to.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/