RE: [PATCH 01/11] MFD: DA9052 MFD core module v8

[Ashish Jangam]

> -----Original Message-----
> From: Mark Brown [mailto:broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx]
> Sent: Thursday, November 24, 2011 5:36 PM
> To: Ashish Jangam
> Cc: arnd@xxxxxxxx; sameo@xxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> Dajun; linaro-dev@xxxxxxxxxxxxxxxx
> Subject: Re: [PATCH 01/11] MFD: DA9052 MFD core module v8
> 
> On Fri, Nov 18, 2011 at 02:49:54PM +0530, Ashish Jangam wrote:
> 
> > +	da9052_i2c->bustype = BUS_I2C;
> 
> bustype should be redundant now, it certianly doesn't seem to be
> referred to in this patch.
This is required in the TSI driver.
> 
> > +/*
> > + * Interrupt controller support for Dilaog DA9052 PMICs.
> 
> This looks very much like it could be replaced with regmap-irq.  The
> code would be slightly less efficient due to the support for sparse
> interrupt registers but it'd be less code.
regmap-irq has a opaque struct regmap_irq_chip_data which has a member
irq_base and this is required for non-primary irqs registration
and also the clean-up function regmap_del_irq_chip() requires it.
So as of now I will keep the current irq implementation as it is. 


N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ0¶ìh®å’i