Re: [PATCH 14/14] crc32: Select an algorithm via kconfig

From: Herbert Xu
Date: Thu Dec 01 2011 - 19:25:19 EST


On Thu, Dec 01, 2011 at 12:15:17PM -0800, Darrick J. Wong wrote:
> Allow the kernel builder to choose a crc32* algorithm for the kernel.
>
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>

I don't like this at all. How do you expect distros or indeed
anyone to make this choice? For generic C implementations like
this we should only have one, and not many.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/