Re: [PATCH 09/11] sched: export task_prio to GPL modules

From: Peter Zijlstra
Date: Thu Dec 01 2011 - 17:10:34 EST


On Thu, 2011-12-01 at 17:04 -0500, Mathieu Desnoyers wrote:
> * Peter Zijlstra (peterz@xxxxxxxxxxxxx) wrote:
> > On Thu, 2011-12-01 at 16:41 -0500, Mathieu Desnoyers wrote:
> > > LTTng needs this symbol to prepend the current task dynamic priority
> > > value to events (optional context information).
> >
> > I absolutely detest exporting such stuff. It propagates the idea that
> > task prio actually means something. Also, modules really shouldn't care.
>
> People debugging their SCHED_FIFO/SCHED_RR applications, as well as
> users of priority-inheritance futexes, may happen to find this
> information extremely useful.
>
> Just saying...

Right until the moment we go do deadlines.. Anyway, it still doesn't
make sense, your sched_switch() tracepoint handler gets this
information, why do you need this export at all?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/