Re: [RFC] cdc-acm: Fix potential deadlock (lockdep warning)

From: Havard Skinnemoen
Date: Wed Nov 23 2011 - 16:03:28 EST


On Wed, Nov 23, 2011 at 11:44 AM, Alan Cox <alan@xxxxxxxxxxxxxxx> wrote:
> Any data owned by the USB part needs to be handled by the USB driver.
> In the case of usb-serial it keeps its own krefs for that because the
> lifetime of the port/USB serial data is not the same as the lifetime of
> the tty itself.

Yes, exactly. But since tty_port already has a kref, why not use that?
It doesn't have any other use currently.

Hmm, a quick grep tells me tty_port_get() and tty_port_put() are
completely unused. What was the intention behind them?

Havard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/