Re: [PATCH RFC] watchdog: add a new driver for VIA chipsets

[Harald Welte]

<disclaimer>
I used to do some work for VIA some years ago but am not anymore, the
email alias mostly exists because I don't want to leave the community
completely in the rain if I can still help with some VIA related issues.
</disclaimer>

On Wed, Nov 23, 2011 at 04:10:51PM +0400, Dmitry Artamonow wrote:

> "via_wdt" seems to be a too generic name. What if someone will want to
> write driver for some incompatible watchdog also made by VIA?
> Maybe it's worth to use something more specific - say, "via_vx8xx_wdt"?

In fact, to the best of my knowledge, all previous VIA x86 chipsets use
the exact same watchdog, i.e. you can go back to Athlon or even earlier
chipsets and will likely find the exact same interface.

> > + * The only way to activate the watchdog timer or to set its period is
> > + * through BIOS setup.
> 
> Why is to rely on BIOS setup? Is there really no information on what
> registers to write to start watchdog? Or you was just lazy to find it?
> It took me less than a minute to google up a datasheet[1] on VX800/VX820
> and it seems to have all needed information to implement proper start()
> and stop() functions. I suppose info on watchdog registers should be
> applicable to VX855 as well - but it's better to check on your hardware
> anyway.

Unfortunately it simply doesn't work.  When I originally implemented a
via_wdt driver some years ago, I couldn't start the watchdog no matter
how hard I tried.  My inquiries into VIA at that point didn't provide
any response either.  In fact, I even feared that nobody might ever have
used that watchdog hardware before ;)

I can ask again, but I'm not sure if it will be any different at that
time..

Regards,
	Harald
-- 
- Harald Welte <HaraldWelte@xxxxxxxxxxx>	    http://linux.via.com.tw/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/