Re: [PATCH 1/2] trace_events_filter: use rcu_assign_pointer() whensetting ftrace_event_call->filter

[Tejun Heo]

Hello,

On Wed, Nov 23, 2011 at 05:40:17PM +0100, Eric Dumazet wrote:
> > -		call->filter = NULL;
> > +		rcu_assign_pointer(call->filter, NULL);
> 
> Its a minor point, but setting a pointer to NULL certainly doesnt need a
> smp_wmb() barrier, so you can use RCU_INIT_POINTER(call->filter, NULL);

Yeap, we don't need it for NULL.  Did that anyway for consistency /
documentation.  Didn't know we had a macro for that.  Neat.  Updating
the patch....

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/