Re: [PATCH 2/2] trace_event_filter: factorize filter creation

[Steven Rostedt]

On Tue, 2011-11-22 at 18:00 -0800, Tejun Heo wrote:
> There are four places where new filter for a given filter string is
> created, which involves several different steps.  This patch factors
> those steps into create_[system_]filter() functions which in turn make
> use of create_filter_{start|finish}() for common parts.
> 
> The only functional change is that if replace_filter_string() is
> requested and fails, creation fails without any side effect instead of
> being ignored.
> 
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> ---
> These two are on top of the current linus/master bbbc4791cd "Merge
> branch 'staging-linus' of git://git.kernel.org/.../gregkh/staging" as
> tip seems to be lagging behind for the moment.
> 
> Thank you.
> 
>  kernel/trace/trace_events_filter.c |  274 ++++++++++++++++++-------------------
>  1 file changed, 137 insertions(+), 137 deletions(-)

For such a change, I would have liked to see more deletions than
insertions. Although, if it removes duplicate code, I'm not against such
a change. I'll look at this more when I get some more time. But just in
case I forget about it (because I wont look at it before my turkey
dinner tomorrow, and will most likely forget about it come next Monday),
please feel free to ping me again next week.

-- Steve



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/