Re: [PATCH v2 2/2] hugetlb: Replace BUG() with BUILD_BUG() for dummy definitions.

From: David Howells
Date: Wed Nov 23 2011 - 06:11:53 EST


David Daney <ddaney.cavm@xxxxxxxxx> wrote:

> From: David Daney <david.daney@xxxxxxxxxx>
>
> The file linux/hugetlb.h has many places where dummy symbols were
> defined so that the main source code would contain fewer:
>
> #ifdef CONFIG_HUGETLBFS
>
> or
>
> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
>
> If there were any misuse of these symbols, the only symptom would be
> an OOPS at runtime. Change the BUG() to BUILD_BUG() to catch
> any such abuse at compile time instead.
>
> Signed-off-by: David Daney <david.daney@xxxxxxxxxx>

Acked-by: David Howells <dhowells@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/