Re: [PATCH] kconfig: Fix checking return value of 'fwrite'

[Jean Sacren]

From: Michal Marek <mmarek@xxxxxxx>
Date: Sun, 20 Nov 2011 14:24:35 +0100
>
> On 7.10.2011 05:29, Arnaud Lacombe wrote:
> > Hi,
> > 
> > 2011/10/6 Reinhard Tartler <Reinhard.Tartler@xxxxxxxxxxxxxxxxxxxxxxxxxx>:
> >> fwrite indicates '1' written member if a zero-length string is written.
> > you forgot the "Signed-off-by: " part :)
> 
> Reinhard, can I assume
> 
> Signed-off-by: Reinhard Tartler
> <Reinhard.Tartler@xxxxxxxxxxxxxxxxxxxxxxxxxx>
> 
> ? The patch is otherwise correct.

I have two reasons to oppose this patch.

1. If 'len' value is zero, there is an issue already and it should be
taken care of _before_ calling fwrite().

2. xfwrite() doesn't fix anything except for the compiler warning. It
assumes this world is perfect and it's definitely not a place to take
care of the zero-length string.

-- 
Jean Sacren
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/