Re: [PATCH 2/2] dma/ep93xx_dma: prevent ep93xx_dma_tasklet() toaccess empty list

From: Mika Westerberg
Date: Wed Nov 23 2011 - 00:12:47 EST


On Tue, Nov 22, 2011 at 02:26:52PM -0600, H Hartley Sweeten wrote:
>
> I still don't like the BUG_ON here. Is it even possible to get here with
> an empty list now that your catching it in the tasklet?

It's there just to make sure that we don't corrupt any memory if the list is
empty because of some other, yet unknown, bug.

>
> But, ep93xx_dma_set_active() also has a BUG_ON test so...
>
> Acked-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/