Re: [PATCH 2/2] misc: ad525x_dpot: Add support for SPI module device table matching

[Arnd Bergmann]

On Friday 18 November 2011, michael.hennerich@xxxxxxxxxx wrote:
> From: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> 
> Passing device name via platform data, is a leftover from times where
> SPI module device table matching was not existent.
> 
> * Add id_table and remove old mechanism.
> (To my knowledge no intree boards affected)
> * Miscellaneous other cleanup.

The patch looks good to me, but please don't do "miscelaneous other cleanup"
in the same patch. I think doing cleanups while you change a driver is
a good idea, just do the extra step to split those out into a cleanup
patch and describe what you do, just like you have split out the bug fix.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/