RE: [PATCH] s3c/s3c24xx: arm: leds: Make s3c24xx LEDS driver usegpiolib

[Stephen Warren]

Denis Kuzmenko wrote at Monday, November 21, 2011 5:28 PM:
> On 11/22/2011 01:39 AM, Stephen Warren wrote:
...
> > Anyway, I guess that means that your patch V1 is at least a pure conversion
> > of the code from custom functions to gpiolib, even if what it was and still
> > is doing doesn't make much sense to me.
> >
> 
> So what do you suggest? Leave original behavior?
> I'd like to remove pull-related actions at all considering:
>  - power consumption
>  - we are both not able to find any sense in that code
>  - s3c2410_gpio_pullup looks like deprecated
>  - can't imagine situation where this change will break functionality
> (of course when this code used to drive actually LED and not something else)

Well, if that works for you, that makes sense to me too.

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/