Re: [PATCH] Remove unneeded include of version.h from arch/hexagon/include/asm/spinlock_types.h

From: Linas Vepstas
Date: Mon Nov 21 2011 - 11:54:23 EST


Acked-by: Linas Vepstas <linasvepstas@xxxxxxxxx>

On 20 November 2011 14:59, Jesper Juhl <jj@xxxxxxxxxxxxx> wrote:
> "make versioncheck" points out that arch/hexagon/include/asm/spinlock_types.h
> does not need to include version.h .
> A quick look at the file seems to confirm its findings, so here's a patch that
> removes the include.
>
> Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
> ---
> Âarch/hexagon/include/asm/spinlock_types.h | Â Â2 --
> Â1 files changed, 0 insertions(+), 2 deletions(-)
>
> ÂPlease note: I've not done any compile tests or other tests to confirm
> Â Â Â Â Â Â Âthis patch since I have no way to build stuff for this
> Â Â Â Â Â Â Âarchitecture, so please review carefully before applying.
>
> diff --git a/arch/hexagon/include/asm/spinlock_types.h b/arch/hexagon/include/asm/spinlock_types.h
> index 5e937af..99b5a75 100644
> --- a/arch/hexagon/include/asm/spinlock_types.h
> +++ b/arch/hexagon/include/asm/spinlock_types.h
> @@ -21,8 +21,6 @@
> Â#ifndef _ASM_SPINLOCK_TYPES_H
> Â#define _ASM_SPINLOCK_TYPES_H
>
> -#include <linux/version.h>
> -
> Â#ifndef __LINUX_SPINLOCK_TYPES_H
> Â# error "please don't include this file directly"
> Â#endif
> --
> 1.7.7.3
>
>
> --
> Jesper Juhl <jj@xxxxxxxxxxxxx> Â Â Â http://www.chaosbits.net/
> Don't top-post http://www.catb.org/jargon/html/T/top-post.html
> Plain text mails only, please.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hexagon" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/