Re: [PATCH] drm, i915: Fix memory leak in i915_gem_busy_ioctl().

From: Daniel Vetter
Date: Mon Nov 21 2011 - 11:22:03 EST


On Wed, Nov 16, 2011 at 12:49:28AM +0600, Rakib Mullick wrote:
>
> A call to i915_add_request() has been made in function i915_gem_busy_ioctl(). i915_add_request can fail,
> so in it's exit path previously allocated memory needs to be freed.
>
> Signed-off-by: Rakib Mullick <rakib.mullick@xxxxxxxxx>

Indeed, nice catch (albeit totally unlikely to be hit, because the error
only happens when the gpu ceases to progress in the ring, so imo not
stable material). Keith, please pick this up for fixes, thanks.

Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
--
Daniel Vetter
Mail: daniel@xxxxxxxx
Mobile: +41 (0)79 365 57 48
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/