Re: [PATCH V2 2/2] usb: dwc3: use debugfs_print_regs32()

From: Greg KH
Date: Fri Nov 18 2011 - 14:49:07 EST


On Fri, Nov 18, 2011 at 02:51:43PM +0100, Alessandro Rubini wrote:
> This a use example of the regs32 utilities in debugfs, although
> this fuse use ":" as separator between name and value, and debugs
> uses "=" (as it looked to me a more common practice).
>
> Signed-off-by: Alessandro Rubini <rubini@xxxxxxxxx>
> Acked-by: Felipe Balbi <balbi@xxxxxx>

I've applied this, but it causes the following complier warnings to be
spit out:

drivers/usb/dwc3/debugfs.c: In function âdwc3_regdump_showâ:
drivers/usb/dwc3/debugfs.c:384:9: warning: passing argument 2 of âdebugfs_print_regs32â discards âconstâ qualifier from pointer target type [enabled by default]
include/linux/debugfs.h:93:5: note: expected âstruct debugfs_reg32 *â but argument is of type âconst struct debugfs_reg32 *â
drivers/usb/dwc3/debugfs.c:380:8: warning: unused variable âiâ [-Wunused-variable]

Alessandro, care to send me a follow-on patch to fix this up?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/