Re: [PATCH] Fix comparison using wrong pointer variable in dma debug code

From: Thomas Jarosch
Date: Fri Nov 18 2011 - 11:47:25 EST


On Thursday, 17. November 2011 21:01:36 Neil Horman wrote:
> Thanks for the catch! Viro just pointed out you can also remove the ?
> true/false changes and extraneous parens, reducing it to:
>
> (a->dev_addr == b->dev_addr) && (a->dev == b->dev)
> But its not strictly necessecary
>
> Acked-by: Neil Horman <nhorman@xxxxxxxxxxxxx>

I'd say just commit the fix, that rarely used function
is not worth the extra effort.

Cheers,
Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/