Re: [Xen-devel] [PATCH 1/3] xen/granttable: Introducing grant tableV2 stucture

From: Ian Campbell
Date: Fri Nov 18 2011 - 05:55:36 EST


Thanks for splitting these up.

On Fri, 2011-11-18 at 10:07 +0000, ANNIE LI wrote:
> [...]

> return value
> + * by bit operations.
> + */
> + int (*query_foreign_access)(grant_ref_t);
> +};
> +
> +static struct gnttab_ops gnttab_v1_ops;

You don't actually need this forward declaration since the struct
definition and usage are ordered correctly.

> +static struct gnttab_ops gnttab_v1_ops = {
> + .map_frames = gnttab_map_frames_v1,
> + .unmap_frames = gnttab_unmap_frames_v1,
> + .update_entry = update_grant_entry_v1,

Any reason this one is not gnttab_foo?

Ian.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/