Re: [PATCH] mm: account reaped page cache on inode cache pruning

[Konstantin Khlebnikov]

Andrew Morton wrote:
> On Fri, 18 Nov 2011 10:42:50 +0400 Konstantin Khlebnikov<khlebnikov@xxxxxxxxxx>  wrote:
>
> > Do we really need separate on-stack reclaim_state structure with single field?
> > Maybe replace it with single long (or even unsigned int) .reclaimed_pages field on task_struct
> > and account reclaimed pages unconditionally.
>
> I don't think it matters a lot - it's either a temporary pointer on the
> stack or a permanent space consumption in the task_struct.

Yes, but currently task_struct has permanent pointer to reclaim_state =)

> The way thing are at present we can easily add new fields if needed.  I
> don't think we've ever done that though.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/