Re: [PATCH v2 0/2] Dummy HPAGE_* constants for!CONFIG_HUGETLB_PAGE

[David Rientjes]

On Thu, 17 Nov 2011, David Daney wrote:

> From: David Daney <david.daney@xxxxxxxxxx>
> 
> After a, somewhat heated, discussion with David Rientjes, I think the
> following approach will work.
> 
> The first patch adds HPAGE_SHIFT, needed by MIPS.
> 
> The second cleans up the exiting HPAGE_MASK and HPAGE_SIZE
> 
> David Daney (2):
>   hugetlb: Provide a default HPAGE_SHIFT if !CONFIG_HUGETLB_PAGE
>   hugetlb: Provide safer dummy values for HPAGE_MASK and HPAGE_SIZE
> 
>  include/linux/hugetlb.h |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> Cc: David Rientjes <rientjes@xxxxxxxxxx>

Nack on both, we already discussed this in the other thread (and I 
wouldn't call it "somewhat heated").

We don't need these dummy definitions at all for any current architectures 
that use them and they should be removed so that any future code using 
them will have the proper dependency on CONFIG_HUGETLB_PAGE.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/