Re: [PATCH] m68k: Remove references to obsolete CONFIG_SERIAL167

[Geert Uytterhoeven]

On Sun, Nov 13, 2011 at 12:02, Paul Bolle <pebolle@xxxxxxxxxx> wrote:
> On Sun, 2011-11-13 at 11:31 +0100, Geert Uytterhoeven wrote:
>> commit 51c9d654c2def97827395a7fbfd0c6f865c26544 ("Staging: delete tty
>> drivers") removed the MVME167 serial driver, but forgot to remove these
>> references.
>>
>> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>> ---
>> Âarch/m68k/Kconfig.devices      |  Â2 +-
>> Âarch/m68k/configs/multi_defconfig  |  Â1 -
>> Âarch/m68k/configs/mvme16x_defconfig | Â Â1 -
>> Â3 files changed, 1 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/m68k/Kconfig.devices b/arch/m68k/Kconfig.devices
>> index 6033f5d..e01eeb2 100644
>> --- a/arch/m68k/Kconfig.devices
>> +++ b/arch/m68k/Kconfig.devices
>> @@ -128,7 +128,7 @@ config DN_SERIAL
>>
>> Âconfig SERIAL_CONSOLE
>> Â Â Â bool "Support for serial port console"
>> - Â Â depends on (AMIGA || ATARI || SUN3 || SUN3X || VME || APOLLO) && (ATARI_MFPSER=y || ATARI_MIDI=y || AMIGA_BUILTIN_SERIAL=y || MULTIFACE_III_TTY=y || SERIAL=y || SERIAL167 || DN_SERIAL)
>> + Â Â depends on (AMIGA || ATARI || SUN3 || SUN3X || VME || APOLLO) && (ATARI_MFPSER=y || ATARI_MIDI=y || AMIGA_BUILTIN_SERIAL=y || MULTIFACE_III_TTY=y || SERIAL=y || DN_SERIAL)
>
> 0) The SERIAL=y part can also be dropped. There's no Kconfig symbol
> SERIAL.

OK, will do.

> 1) I've been looking at this impressive dependency list a few days back.
> My impression was that it can be reduced to only AMIGA_BUILTIN_SERIAL=y.
> (After that this Kconfig symbol might better be renamed to
> AMIGA_BUILTIN_SERIAL_CONSOLE.)
>
> I might have a draft patch to drop the dependencies somewhere. I need to
> have another look at that (draft) patch before I can submit it.

You are right: all drivers (except for AMIGA_BUILTIN_SERIAL) got lost due to
bitrot, or never made it to mainline. Will fix.

But please keep SERIAL_CONSOLE.

BTW, updating the m68k defconfigs is also on my list.

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/