Re: [PATCH v2] x86: remove NX from video bios area

From: H. Peter Anvin
Date: Thu Nov 17 2011 - 09:57:08 EST


On 11/17/2011 12:26 AM, wangyanqing wrote:
>
> +/*we hope this the right video bios range*/
> +#define VIDEO_BIOS_BEGIN 0x000c0000
> +#define VIDEO_BIOS_END 0x000c7fff
> +
> #define BIOS_ROM_BASE 0xffe00000
> #define BIOS_ROM_END 0xffffffff

Ick. This feels increasingly hacky, especially since the above is known
to not be the video BIOS range on a lot of reasons.

There is something much more fundamentally wrong here, including why X
permission is needed for uvesafb at all.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/