Re: [PATCH] pinctrl: Iterate over u300_pmx_mask's in u300_pmx_endisable

From: Linus Walleij
Date: Thu Nov 17 2011 - 03:01:10 EST


On Tue, Nov 15, 2011 at 7:40 AM, Rajendra Nayak <rnayak@xxxxxx> wrote:

> Fix u300_pmx_endisable() to iterate over the list of 'bits' and
> 'mask' populated as part of u300_pmx_functions.mask[]
>
> Signed-off-by: Rajendra Nayak <rnayak@xxxxxx>
> ---
> Linus W,
> I am not sure if this is a right fix. I just stumbled
> upon this while looking at the u300 pinmux driver
> while I was writing one for OMAP. Maybe I am reading
> the code completely wrong, and I don't even have a
> way to test this, so its just compile tested with
> u300_defconfig.

Looks correct and works, I've just been saved by the fact that
most mux settings are in a good default mode when powering
on the system.

Thanks, applied!
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/