Re: [PATCH] fix typo/thinko in get_random_bytes()

From: H. Peter Anvin
Date: Wed Nov 16 2011 - 14:35:48 EST


On 11/16/2011 10:50 AM, Luck, Tony wrote:
> If there is an architecture-specific random number generator we use
> it to acquire randomness one "long" at a time. We should put these
> random words into consecutive words in the result buffer - not just
> overwrite the first word again and again.
>
> Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>

Ouch. Good catch. This, I guess, is the downside of doing this only on
the kernel paths... made this kind of errors harder to catch.

Acked-by: H. Peter Anvin <hpa@xxxxxxxxx>

Linus, do you want to take this one or should I put it in the urgent
queue in tip?

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/