Re: [PATCH] leds: leds-lp3944, fix "sparse" warning "mixingdifferent enum types"

From: Dan Carpenter
Date: Wed Nov 16 2011 - 13:42:11 EST


On Wed, Nov 16, 2011 at 04:00:07PM +0100, Antonio Ospite wrote:
> On Thu, 6 Oct 2011 23:34:44 +0200
> Antonio Ospite <ospite@xxxxxxxxxxxxxxxxx> wrote:
>
> > Fix a warning from "sparse":
> >
> > drivers/leds/leds-lp3944.c:292:23: warning: mixing different enum types
> > drivers/leds/leds-lp3944.c:292:23: int enum led_brightness versus
> > drivers/leds/leds-lp3944.c:292:23: int enum lp3944_status
> >
> > Keeping track of LP3944_LED_STATUS_OFF and LP3944_LED_STATUS_ON only in
> > lp3944_led_set_brightness() is OK, as the handling of DIM (blinking)
> > mode[s] is in lp3944_led_set_blink().
> >
> > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > Signed-off-by: Antonio Ospite <ospite@xxxxxxxxxxxxxxxxx>
>
> Ping.
> Dan, did you receive this one? I can't see it in 3.2-rc2.

Richard is the maintainer, not me. But he's on the CC list as well
so hopefully he can answer your question.

regards,
dan carpenter

Attachment: signature.asc
Description: Digital signature