Re: [PATCH] usb : gadget : usbstring : fix style problems

From: Felipe Balbi
Date: Wed Nov 16 2011 - 06:09:23 EST


On Wed, Nov 16, 2011 at 10:13:02AM +0530, Tonylijo wrote:
> Minor fixes for problems found by checkpatch.pl in usbstring.c.

list here the return from checkpatch.pl --terse just so we know what
you're fixing.

> Signed-off-by: Tonylijo Jose <mail@xxxxxxxxxxx>
> ---
> diff --git a/drivers/usb/gadget/usbstring.c
> b/drivers/usb/gadget/usbstring.c
> index 58c4d37..2bdc56a 100644
> --- a/drivers/usb/gadget/usbstring.c
> +++ b/drivers/usb/gadget/usbstring.c
> @@ -32,8 +32,9 @@ static int utf8_to_utf16le(const char *s, __le16 *cp,
> unsigned len)
> */
> while (len != 0 && (c = (u8) *s++) != 0) {
> if (unlikely(c & 0x80)) {
> - // 2-byte sequence:
> - // 00000yyyyyxxxxxx = 110yyyyy 10xxxxxx
> + /* 2-byte sequence:
> + * 00000yyyyyxxxxxx = 110yyyyy 10xxxxxx
> + */

still wrong. This should've been:

/*
* 2-byte sequence
* 00000yyyyyxxxxxx = 110yyyyy 10xxxxxx
*/

likewise all bellow.

--
balbi

Attachment: signature.asc
Description: Digital signature