Re: [PATCH v2 1/5] dmaengine: add ep93xx DMA support

From: Mika Westerberg
Date: Wed Nov 16 2011 - 02:02:53 EST


On Tue, Nov 15, 2011 at 04:02:05PM +0100, Rafal Prylowski wrote:
>
> 1) Control register is incorrectly programmed for IDE (m2m_hw_setup),
> probably copy-paste bug ;)

Yes, this is certainly a copy-paste bug or something. Thanks for fixing :)

Can you send a separate patch for this? Make sure you Cc Vinod Koul as he is
the maintainer of slave dma subsystem.

> 2) Kernel oops when trying to stop running transfers by calling
> dmaengine_terminate_all(...) - caused by dereferencing empty list
> in ep93xx_dma_get_active

Can you post that OOPS log? I would like to understand this problem a bit
better before we do any fixes for the driver.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/