Re: [PATCHv4] virtio-blk: use ida to allocate disk index

From: Rusty Russell
Date: Mon Oct 31 2011 - 22:17:29 EST


On Mon, 31 Oct 2011 08:05:55 +0100, Jens Axboe <axboe@xxxxxxxxx> wrote:
> On 2011-10-30 20:29, Michael S. Tsirkin wrote:
> > Based on a patch by Mark Wu <dwu@xxxxxxxxxx>
> >
> > Current index allocation in virtio-blk is based on a monotonically
> > increasing variable "index". This means we'll run out of numbers
> > after a while. It also could cause confusion about the disk
> > name in the case of hot-plugging disks.
> > Change virtio-blk to use ida to allocate index, instead.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> > ---
> >
> > Changes from Mark's versions:
> > use the new ida_simple_get
> > error handling cleanup
> > fix user after free
> >
> > Works fine for me.
> >
> > Jens, could you merge this for 3.2?
> > That is, unless Rusty complains shortly ...
>
> Yep, tentatively added.

Thanks!

Acked-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/