Re: [PATCH 12/13] vfs: count unlinked inodes

From: Christoph Hellwig
Date: Fri Oct 28 2011 - 04:29:55 EST


On Fri, Oct 28, 2011 at 10:20:06AM +0200, Miklos Szeredi wrote:
> Okay, so a WARN_ON is not warranted. Perhaps a printk instead?
>
> While initializing nlink with zero normally shouldn't be a problem it
> might indicate something unexpected.

Please do a ratelimited printk. If the log recovery case hits any fs
it will usually do it for tons of inodes in a short period.

Also please try to stick to 80 character lines if possible.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/