[PATCH 2/2] module: Re-enable dynamic debugging for GPL-compatibleOOT modules

From: Ben Hutchings
Date: Thu Oct 27 2011 - 23:38:30 EST


Dynamic debugging was enabled for GPL-compatible out-of-tree modules
until my addition of TAINT_OOT_MODULE. It should continue to be
enabled now.

Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
---
kernel/module.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/module.c b/kernel/module.c
index dab585e..448fd77 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2881,7 +2881,7 @@ static struct module *load_module(void __user *umod,
}

/* This has to be done once we're sure module name is unique. */
- if (!mod->taints || mod->taints == (1U<<TAINT_CRAP))
+ if (!(mod->taints & ~(1U << TAINT_CRAP | 1U << TAINT_OOT_MODULE)))
dynamic_debug_setup(info.debug, info.num_debug);

/* Find duplicate symbols */
@@ -2918,7 +2918,7 @@ static struct module *load_module(void __user *umod,
module_bug_cleanup(mod);

ddebug:
- if (!mod->taints || mod->taints == (1U<<TAINT_CRAP))
+ if (!(mod->taints & ~(1U << TAINT_CRAP | 1U << TAINT_OOT_MODULE)))
dynamic_debug_remove(info.debug);
unlock:
mutex_unlock(&module_mutex);
--
1.7.7


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/