Re: drivers/net/ethernet/apple

[Jeff Kirsher]

On Wed, 2011-10-26 at 22:16 -0700, Geert Uytterhoeven wrote:
> Hi Jeff,
> 
> On Tue, Oct 25, 2011 at 22:19, Geert Uytterhoeven
> <geert@xxxxxxxxxxxxxx> wrote:
> > drivers/net/ethernet/apple/mac89x0.c is a driver for the Crystal
> Semiconductor
> > (Now Cirrus Logic) CS89[02]0, so it belongs in
> drivers/net/ethernet/cirrus,
> > next to cs89x0.c.
> 
> And on the first -next run since its inclusion:
> 
> | drivers/net/ethernet/apple/mac89x0.c:107:20: error: cs89x0.h: No
> such file or directory
> 
> it needs the (shared) header file which is in
> drivers/net/ethernet/cirrus/.
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/4835488/ 

Ah, yeah, now it is coming back to me why I placed cs89x0.[ch] in the
drivers/net/ethernet/apple/ because it was grouped with the "common"
drivers.  The intent was to group drivers that use common code together.

I can put together a patch to fix this if you are not able to.

Attachment: signature.asc
Description: This is a digitally signed message part