Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order inpmcraid_chr_ioctl()

[Jesper Juhl]

On Tue, 25 Oct 2011, richard -rw- weinberger wrote:

> On Tue, Oct 25, 2011 at 12:42 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> > On Tue, 2011-10-25 at 00:38 +0200, Jesper Juhl wrote:
> >> The first argument to kmalloc() is the size, the second is
> >> flags. pmcraid_chr_ioctl() gets this wrong and swaps the
> >> arguments. This patch corrects the mistake.
> >>
> >> Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
> >> ---
> >>  drivers/scsi/pmcraid.c |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >>  compile tested only.
> >>
> >> diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
> >> index d079f9a..da19bdf 100644
> >> --- a/drivers/scsi/pmcraid.c
> >> +++ b/drivers/scsi/pmcraid.c
> >> @@ -4103,7 +4103,7 @@ static long pmcraid_chr_ioctl(
> >>       struct pmcraid_ioctl_header *hdr = NULL;
> >>       int retval = -ENOTTY;
> >>
> >> -     hdr = kmalloc(GFP_KERNEL, sizeof(struct pmcraid_ioctl_header));
> >> +     hdr = kmalloc(sizeof(struct pmcraid_ioctl_header), GFP_KERNEL);
> >>
> >>       if (!hdr) {
> >>               pmcraid_err("faile to allocate memory for ioctl header\n");
> >> --
> >> 1.7.7
> >>
> >>
> >
> > James seems to be uninterested in picking up
> > obvious and trivially correct patches.
> >
> 
> BTW: What about a checkpatch.pl rule to detect such a misuse of kmalloc()?
> We could grep for "k[mzc]alloc(GFP_".
> 
I like that idea. That's exactely how I find these; by doing 
egrep -R "[kv][mcz]alloc *\( *GFP_" 
on the source tree.
Might as well be in checkpatch.pl

-- 
Jesper Juhl <jj@xxxxxxxxxxxxx>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.