Re: -next: NET_VENDOR_8390 dependencies

[Jeff Kirsher]

On Sun, 2011-10-23 at 14:21 -0700, Geert Uytterhoeven wrote:
> drivers/net/ethernet/8390/Kconfig:
> 
> config NET_VENDOR_8390
>         bool "National Semi-conductor 8390 devices"
>         default y
>         depends on NET_VENDOR_NATSEMI && (AMIGA_PCMCIA || PCI || SUPERH || \
>                    ISA || MCA || EISA || MAC || M32R || MACH_TX49XX || \
>                    MCA_LEGACY || H8300 || ARM || MIPS || ZORRO || PCMCIA || \
>                    EXPERIMENTAL)
>         ---help---
>           If you have a network (Ethernet) card belonging to this class, say Y
>           and read the Ethernet-HOWTO, available from
>           <http://www.tldp.org/docs.html#howto>.
> 
>           Note that the answer to this question doesn't directly affect the
>           kernel: saying N will just cause the configurator to skip all
>           the questions about Western Digital cards. If you say Y, you will be
>           asked for your specific card in the following questions.
> 
> So NET_VENDOR_8390 depends on NET_VENDOR_NATSEMI.
> 
> drivers/net/ethernet/natsemi/Kconfig:
> 
> config NET_VENDOR_NATSEMI
>         bool "National Semi-conductor devices"
>         default y
>         depends on MCA || MAC || MACH_JAZZ || PCI || XTENSA_PLATFORM_XT2000
>         ---help---
>           If you have a network (Ethernet) card belonging to this class, say Y
>           and read the Ethernet-HOWTO, available from
>           <http://www.tldp.org/docs.html#howto>.
> 
>           Note that the answer to this question doesn't directly affect the
>           kernel: saying N will just cause the configurator to skip all
>           the questions about National Semi-conductor devices. If you say Y,
>           you will be asked for your specific card in the following questions.
> 
> But NET_VENDOR_NATSEMI will never be true for several of the other
> dependencies of NET_VENDOR_8390 (e.g. AMIGA_PCMCIA, EISA, H8300, ARM,
> ZORRO, PCMCIA)?
> 

You are correct, I will put together a patch to fix that.  Thanks!

Attachment: signature.asc
Description: This is a digitally signed message part