Re: [PATCH 01/10] dmaengine: add new enum dma_transfer_direction

[Barry Song]

2011/10/15 Russell King <rmk@xxxxxxxxxxxxxxxx>:
> On Fri, Oct 14, 2011 at 11:08:16AM +0530, Vinod Koul wrote:
>> This new enum removes usage of dma_data_direction for dma direction. The new
>> enum cleans tells the DMA direction and mode
>> This further paves way for merging the dmaengine _prep operations and also for
>> interleaved dma
>>
>> Suggested-by: Jassi Brar <jaswinder.singh@xxxxxxxxxx>
>> Signed-off-by: Vinod Koul <vinod.koul@xxxxxxxxxxxxxxx>
>> ---
>> Âinclude/linux/dmaengine.h | Â 22 +++++++++++++++++-----
>> Â1 files changed, 17 insertions(+), 5 deletions(-)
>>
>> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
>> index ace51af..24942ad 100644
>> --- a/include/linux/dmaengine.h
>> +++ b/include/linux/dmaengine.h
>> @@ -23,7 +23,6 @@
>>
>> Â#include <linux/device.h>
>> Â#include <linux/uio.h>
>> -#include <linux/dma-direction.h>
>> Â#include <linux/scatterlist.h>
>>
>> Â/**
>> @@ -75,6 +74,19 @@ enum dma_transaction_type {
>> Â/* last transaction type for creation of the capabilities mask */
>> Â#define DMA_TX_TYPE_END (DMA_CYCLIC + 1)
>>
>> +/**
>> + * enum dma_transfer_direction - dma transfer mode and direction indicator
>> + * @MEM_TO_MEM: Async/Memcpy mode
>> + * @MEM_TO_DEV: Slave mode & From Memory to Device
>> + * @DEV_TO_MEM: Slave mode & From Device to Memory
>> + * @DEV_TO_DEV: Slave mode & From Device to Device
>> + */
>> +enum dma_transfer_direction {
>> + Â Â MEM_TO_MEM,
>> + Â Â MEM_TO_DEV,
>> + Â Â DEV_TO_MEM,
>> + Â Â DEV_TO_DEV,
>> +};
>>
>> Â/**
>> Â * enum dma_ctrl_flags - DMA flags to augment operation preparation,
>> @@ -267,7 +279,7 @@ enum dma_slave_buswidth {
>> Â * struct, if applicable.
>> Â */
>> Âstruct dma_slave_config {
>> - Â Â enum dma_data_direction direction;
>> + Â Â enum dma_transfer_direction direction;
>
> I thought we were killing this off - surely now is a good time, rather
> than allowing it to persist with this ambiguous change of functionality.
>
>> Â Â Â dma_addr_t src_addr;
>> Â Â Â dma_addr_t dst_addr;
>> Â Â Â enum dma_slave_buswidth src_addr_width;
>> @@ -490,11 +502,11 @@ struct dma_device {
>>
>> Â Â Â struct dma_async_tx_descriptor *(*device_prep_slave_sg)(
>> Â Â Â Â Â Â Â struct dma_chan *chan, struct scatterlist *sgl,
>> - Â Â Â Â Â Â unsigned int sg_len, enum dma_data_direction direction,
>> + Â Â Â Â Â Â unsigned int sg_len, enum dma_transfer_direction direction,
>
> Does this make any sense? ÂThe API takes a single scatterlist of memory
> locations - so MEM_TO_MEM and DEV_TO_DEV are meaningless for this API.

so people don't give MEM_TO_MEM and DEV_TO_DEV to this function.  This
function only accept a subset of the data_transfer_direction.

if we use dma_data_direction,  this function doesn't accept
DMA_BIDIRECTIONAL and DMA_NONE as well:
  enum dma_data_direction {
          DMA_BIDIRECTIONAL = 0,
          DMA_TO_DEVICE = 1,
          DMA_FROM_DEVICE = 2,
          DMA_NONE = 3,
  };
DMA_BIDIRECTIONAL and DMA_NONE are also meaningless for this API.

i think this patch makes sense if we consider dma_data_direction is
actually mapping direction. dma_transfer_direction is a new structure
describling the real dma source and dest. and the new interleaved api
will accept all 4 directions.

>
> If it took two scatterlists and two device addresses, then maybe it would -
> but I don't see the point of this change (and all the users of this API
> also needing to change) when the API is specifically for memory scatterlist
> to/from a device.
>
> --
> Russell King
> ÂLinux kernel  Â2.6 ARM Linux  - http://www.arm.linux.org.uk/
> Âmaintainer of:
>
-barry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/