Re: [PATCH v2] Documentation/power: Update docs about suspend andCPU hotplug

[Alan Stern]

On Fri, 14 Oct 2011, Srivatsa S. Bhat wrote:

> Update the documentation about the interaction between the suspend (S3) call
> path and the CPU hotplug infrastructure.
> This patch focusses only on the activities of the freezer, cpu hotplug and
> the notifications involved. It outlines how regular CPU hotplug differs from
> the way it is invoked during suspend and also tries to explain the locking
> involved.
> 
> v2: Clarified the question, to emphasize that the document explains only
>     the difference (and similarity) in the two code paths but not what happens
>     when race conditions occur between them.

Drawing the two diagrams in parallel, the way this does, carries a very
strong implication that the events being described happen in parallel.  
It really would be much better to have two separate diagrams and point
out the common portions.

Also, the document should discuss the issues involved in CPU hotplug.  
In particular, what happens if the CPUs are not all the same, or if the 
requiring differing microcodes.  And whether or not the microcode needs 
to get reloaded (presumably only after hibernation, not after suspend).
And what happens when a CPU is hot-unplugged and replaced with a 
differeing CPU which is then hot-plugged.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/