Re: [PATCH 5/5 v14] omap: usb: host: Replace usbhs core driver APIsby Runtime pm APIs

From: Alan Stern
Date: Thu Oct 13 2011 - 14:12:04 EST


On Thu, 13 Oct 2011, Felipe Balbi wrote:

> Hi,
>
> On Tue, Oct 11, 2011 at 01:22:11PM +0530, Keshava Munegowda wrote:
> > From: Keshava Munegowda <Keshava_mgowda@xxxxxx>
> >
> > The ehci and ohci drivers does not use the APIs of the usbhs
> > core driver; the runtime pm APIs are used for clock
> > enable/disable. Since usbhs is parent platform device of the
> > ehci and ohci devices, the runtime apis indirectly uses the
> > usb hs core device as input parameter to for clock functions.
> >
> > Signed-off-by: Keshava Munegowda <keshava_mgowda@xxxxxx>
> > Reviewed-by: Kevin Hilman <khilman@xxxxxx>
> > Reviewed-by: Partha Basak <parthab@xxxxxxxxxxxx>
>
> I'm not sure who should queue this one. Alan, maybe ?

All my stuff goes by way of Greg in any case.

> FWIW:
>
> Acked-by: Felipe Balbi <balbi@xxxxxx>
>
> as an extra comment, this patch has a very deep dependency on the hwmod
> conversion patches which come before this. If those aren't applied on
> the same merge window, we will have a non-working *HCI driver on OMAP.

To keep things simple, this patch should go through the same submission
path as the others in the series. I view it more as an OMAP thing than
an EHCI thing anyway. For the record:

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/