Re: [Patch] Increase USBFS Bulk Transfer size

From: Chris Friesen
Date: Thu Oct 13 2011 - 12:01:37 EST


On 10/13/2011 09:19 AM, Markus Rechberger wrote:
On Thu, Oct 13, 2011 at 4:58 PM, Alan Stern<stern@xxxxxxxxxxxxxxxxxxx> wrote:

This is very interesting. There are only two things that could be
happening: Either the device sends different data during the two tests,
or there's a bug in the kernel.

Before that I insist that this patch will go into the kernel (I know
that sounds ridiculous but so far I did everything
you requested me to do), I clearly pointed out that we even have hardware
specs which can influence the transfer buffer. The patch does not hurt
and makes the device work.

That makes no sense. If there's a bug in the hardware we likely don't want to make global changes to work around it--a more targeted fix may be more appropriate.

If there is a bug in the kernel, why would we want a bandaid patch that just happens to make it work rather than a true fix?

Chris

--
Chris Friesen
Software Developer
GENBAND
chris.friesen@xxxxxxxxxxx
www.genband.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/