Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

From: Kumar Gala
Date: Wed Oct 12 2011 - 16:58:22 EST



On Oct 12, 2011, at 3:23 PM, Hans J. Koch wrote:

> On Wed, Oct 12, 2011 at 01:40:22PM -0500, Kumar Gala wrote:
>>
>> On Oct 12, 2011, at 11:19 AM, Hans J. Koch wrote:
>>
>>> On Wed, Oct 12, 2011 at 05:32:29PM +0200, Hans J. Koch wrote:
>>>> On Wed, Oct 12, 2011 at 09:35:45AM -0500, Kumar Gala wrote:
>>>>> From: Kai Jiang <Kai.Jiang@xxxxxxxxxxxxx>
>>>>>
>>>>> To support >32-bit physical addresses for UIO_MEM_PHYS type we need to
>>>>> extend the width of 'addr' in struct uio_mem. Numerous platforms like
>>>>> embedded PPC, ARM, and X86 have support for systems with larger physical
>>>>> address than logical.
>>>>>
>>>>> Since 'addr' may contain a physical, logical, or virtual address the
>>>>> easiest solution is to just change the type to 'unsigned long long'
>>>>> regardless of which type is utilized.
>>>>
>>>> No. There's phys_addr_t for that purpose, defined in include/linux/types.h.
>>>> Please use that.
>>>
>>> I forgot: If you resend this, please update the documentation as well.
>>> (Documentation/DocBook/uio-howto.tmpl)
>>
>> What would you look added or modified here?
>
> struct uio_mem ?
>
> Hans

New version sent, let me know if there are any other aspects to the DocBook that need updating.

- k--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/