Re: [PATCH] cy82c693: fix PCI device selection

[Bartlomiej Zolnierkiewicz]

David Miller wrote:

> From: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
> Date: Tue, 11 Oct 2011 19:37:32 +0200
> 
> > While at it remove redundant pci_get_slot() call as cy82c693_init_one()
> > already takes care of keeping the reference on the second port's PCI
> > device.
> 
> Please do not submit unrelated changes with a bug fix, and as IDE is
> in long-term maintainence I would not accept a risky refinement like
> this anyways.

Removed code is just bogus, we cannot fail in ->set_pio_mode method.

Please take a look at the code:
 
-	/* select primary or secondary channel */
-	if (hwif->index > 0) {  /* drive is on the secondary channel */
-		dev = pci_get_slot(dev->bus, dev->devfn+1);
-		if (!dev) {
-			printk(KERN_ERR "%s: tune_drive: "
-				"Cannot find secondary interface!\n",
-				drive->name);
-			return;
-		}
-	}

Please apply the patch, libata's pata_cypress doesn't support secondary
port currently and cy82c693 driver is the only way to use this hardware.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/