RE: [PATCH] gpio/samsung: Move SoC specific codes within macro

From: Kukjin Kim
Date: Wed Oct 12 2011 - 08:42:35 EST


Kukjin Kim wrote:
>
> Grant Likely wrote:
> >
> > On Mon, Oct 03, 2011 at 08:59:19AM +0530, Tushar Behera wrote:
> > > In drivers/gpio/gpio-samsung.c, there are certain structures
> > > and functions which are not getting used if the particular
> > > CPU is not selected. These code segments are moved under CPU
> > > specific macros to remove compilation warnings.
> > >
> > > Signed-off-by: Tushar Behera <tushar.behera@xxxxxxxxxx>
> >
> > Acked-by: Grant Likely <grant.likely@xxxxxxxxxxxx>
> >
> When I applied, following error was happened with s5p64x0_defconfig.
Others, ok.
>
> ...
> Inconsistent kallsyms data
> This is a bug - please report about it
> Try make KALLSYMS_EXTRA_PASS=1 as a workaround
> make: *** [vmlinux] Error 1
>
> And it seems due to add condition around the 'static unsigned
> s3c24xx_gpio_getcfg_abank()'.
>
> I need to check it in detail and if any problems, let you know.
>
There is no above problem now in my -next. Applied.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/