RE: [PATCH] kconfig: fix warnings due to unused return values

From: Premi, Sanjeev
Date: Wed Oct 12 2011 - 08:30:45 EST


> -----Original Message-----
> From: linux-kernel-owner@xxxxxxxxxxxxxxx
> [mailto:linux-kernel-owner@xxxxxxxxxxxxxxx] On Behalf Of
> Premi, Sanjeev
> Sent: Friday, October 07, 2011 2:49 PM
> To: Michal Marek
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Subject: RE: [PATCH] kconfig: fix warnings due to unused return values
>
> > -----Original Message-----
> > From: Michal Marek [mailto:mmarek@xxxxxxx]
> > Sent: Wednesday, October 05, 2011 8:38 PM
> > To: Premi, Sanjeev
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > Subject: Re: [PATCH] kconfig: fix warnings due to unused
> return values
> >
> > On 22.9.2011 13:36, Sanjeev Premi wrote:
> > > The return value of wattrset() is being ignored in the
> > > code and newer compilers complain about this e.g.
> > >
> > > HOSTCC scripts/kconfig/lxdialog/checklist.o
> > > scripts/kconfig/lxdialog/checklist.c: In function print_item:
> > > scripts/kconfig/lxdialog/checklist.c:40: warning: value
> > computed is not used
> > > scripts/kconfig/lxdialog/checklist.c:46: warning: value
> > computed is not used
> > >
> > > Let the compiler know that ignore is intentional.
> > >
> > > Signed-off-by: Sanjeev Premi <premi@xxxxxx>
> > > ---
> > >
> > > The patch was created against the last pull from git.kernel.org
> > > The 'pull' from github is taking more than few hours...
> > >
> > > Based on the time stamps at this url, I believe the patch should
> > > apply cleanly:
> > >
> >
> https://github.com/torvalds/linux/tree/master/scripts/kconfig/lxdialog
> >
> > The latest kconfig tree is at http://repo.or.cz/w/linux-kbuild.git,
> > branch kconfig. You can pull it by
> >
> > $ git fetch git://repo.or.cz/linux-kbuild.git kconfig:kconfig
>
> Sure, I will pull it.

I tried the menuconfig after pulling from this repo and still see the
same warnings.

For reference, the HEAD is at:
commit 93072c3ecafcf188390750cc755185f3150736b9
scripts/kconfig/nconf: add KEY_HOME / KEY_END for dialog_inputbox

[snip]...[snip]

>
> I am on Ubuntu 10.04.1 LTS
>
> premi #
> premi # gcc --version
> gcc (Ubuntu 4.4.3-4ubuntu5) 4.4.3
> Copyright (C) 2009 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.
> There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A
> PARTICULAR PURPOSE.
> premi #
> premi #
> premi # dpkg --get-selections | grep curses
> lib32ncurses5 install
> libcurses-perl install
> libcurses-ui-perl install
> libncurses5 install
> libncurses5-dev install
> libncursesw5 install
> ncurses-base install
> ncurses-bin install
> premi #

This information is in my previous mail, but keeping here just
for easy reference.

~sanjeev

[snip]...[snip]

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/