Re: [PATCH 2/2] Staging: comedi: fix printk and line over 80

From: Valdis . Kletnieks
Date: Tue Oct 11 2011 - 17:34:42 EST


On Mon, 10 Oct 2011 19:28:53 +0530, Ravishankar Karkala Mallikarjunayya said:
> This patch fixes a printk and line over 80 charcter found by the
> checkpatch.pl tool

> @@ -503,7 +512,7 @@ static int probe(struct comedi_device *dev, const struct comedi_devconfig *it)
> }
> }
>
> - printk("cb_pcimdda: No supported ComputerBoards/MeasurementComputing "
> + pr_err("cb_pcimdda: No supported ComputerBoards/MeasurementComputing "
> "card found at the requested position\n");
> return -ENODEV;
> }

As long as we're changing this code, should we be splicing the two parts of the
string back together? (And yes, that *does* trump the 80-col rule)

Attachment: pgp00000.pgp
Description: PGP signature