Re: [PATCH v2 2/3] Mutually exclude cpu online andsuspend/hibernate

From: Peter Zijlstra
Date: Tue Oct 11 2011 - 05:12:29 EST


On Mon, 2011-10-10 at 10:00 -0700, Tejun Heo wrote:

> On Mon, Oct 10, 2011 at 06:15:20PM +0530, Srivatsa S. Bhat wrote:
> > Would it be better to hook into the suspend/hibernate notifiers and
> > use them to exclude cpu hotplug from suspend/hibernate, instead of
> > trying to take pm_mutex lock like this?
>
> If this change is determined to be necessary, I think it would be
> better to make it explicit. Exclusion through callbacks often makes
> the locking just more obscure.

Agreed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/