Re: [PATCH 1/5 v13] arm: omap: usb: ehci and ohci hwmod structuresfor omap4

From: Paul Walmsley
Date: Mon Oct 10 2011 - 18:13:42 EST


Hi

On Mon, 10 Oct 2011, Paul Walmsley wrote:

> So then you'd just create a TLL driver with something like these two
> symbols exported:
>
> omap_usbhost_tll_enable_port();
> omap_usbhost_tll_disable_port();

N.B., since I don't think Linux has any formal support to map USB ports to
TLL ports, you'll probably need to create a couple of functions in your
drivers/mfd/omap-usb-host.c that your EHCI/OHCI drivers could call during
init/exit to get and put the TLL struct device, to pass to those above
functions. Since the MFD driver is what creates the TLL struct devices,
the MFD driver will have the TLL struct device pointers. Something like
omap_usbhost_get_tll_device() and omap_usbhost_put_tll_device().

One other thing. Not sure what the correct generic name prefix for these
functions should be, since I don't know the provenance of the USBHOST IP
block; but maybe the function prefix should be something like 'ti_usbhost'
instead, to indicate that it isn't OMAP-specific? You would know better
than I.


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/