Re: [PATCH] trivial: fix typos in Documentation/edac.txt andDocumentation/filesystems/ext4.txt

[Borislav Petkov]

On Mon, Oct 10, 2011 at 12:38:16PM -0400, Raoul Bhatia [IPAX] wrote:
> Fixing trivial typos in
> Documentation/edac.txt and
> Documentation/filesystems/ext4.txt
> 
> patch for current git head checkout from
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> 
> Signed-off-by: Raoul Bhatia <r.bhatia@xxxxxxx>
> ---
> diff --git a/Documentation/edac.txt b/Documentation/edac.txt
> index 249822c..8ba7bb4 100644
> --- a/Documentation/edac.txt
> +++ b/Documentation/edac.txt
> @@ -643,7 +643,7 @@ There is a three level tree beneath the above 'edac' 
> directory. For example,
>   the 'test_device_edac' device (found at the bluesmoke.sourceforget.net 
> website)
>   installs itself as:
> 
> -	/sys/devices/systm/edac/test-instance
> +	/sys/devices/system/edac/test-instance
> 
>   in this directory are various controls, a symlink and one or more 
> 'instance'
>   directorys.
> diff --git a/Documentation/filesystems/ext4.txt 
> b/Documentation/filesystems/ext4.txt
> index 232a575..a8356c3 100644
> --- a/Documentation/filesystems/ext4.txt
> +++ b/Documentation/filesystems/ext4.txt
> @@ -352,7 +352,7 @@ noinit_itable		Do not initialize any uninitialized 
> inode table
>   init_itable=n		The lazy itable init code will wait n times the
>   			number of milliseconds it took to zero out the
>   			previous block group's inode table.  This
> -			minimizes the impact on the systme performance
> +			minimizes the impact on the system performance
>   			while file system's inode table is being initialized.
> 
>   discard			Controls whether ext4 should issue discard/TRIMa

Right, a couple of suggestions:

* please don't mix different subsystems in a single patch: EDAC should be one
patch and fs another.

* Documentation/edac.txt is pretty old and has more errors than this one
so it would be much better to create a single patch which scrubs that
file properly and thoroughly.

Also, while you're at it, please run the driver and verify that all the
functionality described there actually works and document any changes
you might find which are deviating from the document. And if anything is
broken, you might even try to fix it, if you'd like :-) - patches are
always welcome.

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/