Re: [PATCH 1/6] udf: Promote some debugging messages to udf_error

[Jan Kara]

On Mon 10-10-11 01:08:02, Joe Perches wrote:
> If there is a problem with a scratched disc or loader,
> it's valuable to know which error occurred.
> 
> Convert some debug messages to udf_error, neaten those messages too.
> Add the calculated tag checksum and the read checksum to error message.
> Make udf_error a public function and move the logging prototypes together.
> 
> Original-patch-by: NamJae Jeon <linkinjeon@xxxxxxxxx>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
  I have now tested this patch and found out it's not such a good idea as
it seems at the first sight. UDF uses udf_read_tagged() to probe whether
some structure is in some location (because some structures can be placed
at several places in the filesystem and the only way to determine where the
structure is to load blocks from all the places and check block headers).
So as a result of this patch normal UDF mount produces about 20 error
messages... So I've altered this patch to change only some messages in
udf_read_tagged(). The result is below.

								Honza

-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
---