Re: [PATCH v2 0/3] Freezer, CPU hotplug, x86 Microcode: Fix taskfreezing failures

From: Tejun Heo
Date: Mon Oct 10 2011 - 12:58:03 EST


Hello, Alan.

On Mon, Oct 10, 2011 at 11:23:13AM -0400, Alan Stern wrote:
> Furthermore, if the entire problem is lack of CPU microcode, hasn't
> that been fixed already? There recently was a patch to avoid releasing
> microcode after it was first loaded -- the idea being that there would
> then be no need to get the microcode from userspace again at awkward
> times while the system is resuming.

It's a deadlock problem. Currently, the code allows actual CPU
hotplug (which naturally requires loading microcode using userland
helper) and system suspend to race. CPU hotplug won't be able to make
progress as microcode can't be loaded due to on-going freezing and
system suspend will eventually time out waiting for CPU hotplug to
finish. The two operations need to be serialized.

Or are you arguing that initiating CPU hotplug operation while system
suspend is in progress is user error and we don't need to worry about
this? Maybe that isn't such a bad idea either.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/